Skip to content

[cuegui] Kill a Job from Windows. #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DiegoTavares merged 1 commit into from
Oct 1, 2024
Merged

[cuegui] Kill a Job from Windows. #1520

DiegoTavares merged 1 commit into from
Oct 1, 2024

Conversation

@KernAttila
Copy link
Contributor

@KernAttila KernAttila commented Sep 29, 2024 •
edited
Loading

Link the Issue(s) this Pull Request is related to.
Fixes: #1519

Summarize your change.
Use platform.uname() instead of os.uname(). They have the same result on Linux, but os.uname() is not available on Windows, making us unable to kill a job from this OS.

Additional information.
Linux (ubuntu 22.04.6):

>>> os.uname()
posix.uname_result(sysname='Linux', nodename='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64')
>>>platform.uname()
uname_result(system='Linux', node='titan', release='6.8.0-45-generic', version='#45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Wed Sep 11 15:25:05 UTC 2', machine='x86_64')

Windows (11):

>>> platform.uname()
uname_result(system='Windows', node='StarChaser', release='10', version='10.0.22631', machine='AMD64')

@KernAttila
fix: use platform.uname() instead of os.uname(). They have the same r…
b98758a 
…esult on Linux, but os.uname() is not available on Windows, making us unable to kill a job from this OS.
@KernAttila KernAttila changed the title Kill a Job from CueGui running on Windows. [cuegui] Kill a Job from Windows. Sep 29, 2024
@DiegoTavares DiegoTavares merged commit 8f7f23c into AcademySoftwareFoundation:master Oct 1, 2024
@KernAttila KernAttila deleted the cuegui-kill-job-windows branch October 1, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoTavares DiegoTavares DiegoTavares approved these changes

@bcipriano bcipriano Awaiting requested review from bcipriano

@ramonfigueiredo ramonfigueiredo Awaiting requested review from ramonfigueiredo ramonfigueiredo is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't kill a job from CueGui if running on Windows

2 participants

@KernAttila @DiegoTavares