[cuegui] Add dynamic version fetching for the CueGUI About menu #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented new configuration options in cuegui.yaml: - `cuegui.use.custom.version`: Toggle between using VERSION.in or dynamic spawn version. - `cuegui.custom.cmd.version.stable`: Command to fetch stable version from spawn. - `cuegui.custom.cmd.version.beta`: Command to fetch beta version from spawn. - Modified Constants.py to fetch version dynamically based on config. - Updated MainWindows.py to display the correct version (stable or beta) in the About menu. - Fallback to VERSION.in if custom version is disabled.
CueGUI About menuIf you go to the CueGUI
The current version doesn't show the CueGUI version, only QT and Python versionsCuetopia Cuecommander New solution: If
|
|
The reason for giving the option to show the custom CueGUI version using a shell command:
|
DiegoTavares
requested changes
Sep 26, 2024
Co-authored-by: Diego Tavares <[email protected]> Signed-off-by: Ramon Figueiredo <[email protected]>
ramonfigueiredo
force-pushed
the
dynamic-version-about-menu
branch
from
b0931a3 to
8f02f32
Compare
Co-authored-by: Diego Tavares <[email protected]> Signed-off-by: Ramon Figueiredo <[email protected]>
Co-authored-by: Diego Tavares <[email protected]> Signed-off-by: Ramon Figueiredo <[email protected]>
- Added `check=True` to subprocess.run to raise errors on non-zero exit codes. - Added handling for `subprocess.CalledProcessError` to improve error reporting. - Ensured more robust command execution with explicit failure handling.
DiegoTavares
approved these changes
Sep 26, 2024
ramonfigueiredo
merged commit 4e0ec97
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuegui.use.custom.version: Toggle between using VERSION.in or custom CueGUI version.cuegui.custom.cmd.version.stable: Command to fetch stable version (setenv OPENCUE_BETA 0)cuegui.custom.cmd.version.beta: Command to fetch beta version (setenv OPENCUE_BETA 1)