[cuegui] Remove constants test that is not testing constants #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unit test `test__should_use_default_values` which is a recipe for problems when deploying cuegui. The test was supposed to confirm constants defaults are set properly, but the current implementation applies values from cuegui.yaml, which is supposed to be configured by users to match their local requirements. With this, running the unit test locally after configuring cuegui.yaml will always fail. The test itself didn't accomplish much, so I suggest removing it altogether.
DiegoTavares
force-pushed
the
remove_cuegui_defaults_test
branch
from
5435274 to
2faaab7
Compare
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
changed the title
ramonfigueiredo
approved these changes
Sep 6, 2024
|
FYI @bcipriano |
DiegoTavares
merged commit 7ebecc0
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unit test
test__should_use_default_valueswhich is a recipe for problems when deploying cuegui. The test was supposed to confirm constants defaults are set properly, but the current implementation applies values from cuegui.yaml, which is supposed to be configured by users to match their local requirements. With this, running the unit test locally after configuring cuegui.yaml will always fail.The test itself didn't accomplish much, so I suggest removing it altogether.