[rqd] Fix permission issues when becoming a user #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes implemented by AcademySoftwareFoundation#1416 impacted the locking mechanism for handling permissions on rqd, causing multiple threads to compete for permission settings and access to passwd. Besides fixing the bug, this PR also introduces a fix for a potential security issue that would allow frames to run as root if the frame user didn't exist and the process to create this user fails.
DiegoTavares
changed the title
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
changed the title
ramonfigueiredo
approved these changes
Sep 6, 2024
| cmd.append(username) | ||
| log.info("Frame's username not found on host. Adding user with: %s", cmd) | ||
| subprocess.check_call(cmd) | ||
| # Multiple processes can be trying to access passwd, permissionHigh and |
Collaborator
There was a problem hiding this comment.
Fix comment:
passwd?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes implemented by #1416 impacted the locking mechanism for handling permissions on rqd, causing multiple threads to compete for permission settings and access to passwords.
Besides fixing the bug, this PR also introduces a fix for a potential security issue that would allow frames to run as root if the frame user didn't exist and the process to create this user fails.