Skip to content

[cuegui] Allow previewing checkpointed frames #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DiegoTavares
Copy link
Collaborator

@DiegoTavares DiegoTavares commented Aug 21, 2024

Some Digital Content Creation tools (DCCs) provide a preview of the images being rendered using a local server. This feature allows capturing a preview on a tmp directory for displaying using the configured viewer.

For this to work, the host running the frame being previewed needs to have the port being used by the DCC accessible. The hostname is used as the URL and the port is captured from the frame logs, as DCCs with this feature usually output the port in the first lines of the log file.

One last change on this PR is to make sure both Preview and View Output options are only displayed when the viewer cmd pattern is configured on cuegui.yaml.

ViewOutput and PreviewMain actions should only be displayed if an output viewer is configured on cuegui.yaml under output_viewer.
@DiegoTavares DiegoTavares force-pushed the fix_frame_preview_checkpoint branch from 6d87d4a to 2817cef Compare August 21, 2024 18:38
@DiegoTavares DiegoTavares force-pushed the fix_frame_preview_checkpoint branch from 2817cef to e968750 Compare August 21, 2024 18:55
@DiegoTavares DiegoTavares marked this pull request as ready for review August 21, 2024 19:37
Copy link
Collaborator

@ramonfigueiredo ramonfigueiredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DiegoTavares

Approved with minor changes!

@DiegoTavares DiegoTavares merged commit 0e4cee0 into AcademySoftwareFoundation:master Aug 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants