[cuegui] Reduce page size for FrameSearch and reuse config on FrameMonitor widget #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes to search Reducing the number of frames to search to improve gui performance for large jobs
|
|
Roula's contribution on this PR happened while she was still at SPI. Even though she has signed the CLA, the check will fail as the email assigned to this commit is no longer associated with her github account. |
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
approved these changes
Aug 20, 2024
DiegoTavares
merged commit cd5b836
into
AcademySoftwareFoundation:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the limit of frames queried by FrameSearch by half. It was identified that the GUI becomes unusable with 1000 frames being displayed at the same time.
FrameMonitor was also updated to stop using a hardcoded value for the limit and start reusing the same value from the API.