[cuegui] Add an option to list FilterDialog actions that should be hidden from the option list #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constant has been moved to the config file and properly documented.
|
Collaborator
Author
|
@tomi-lui's contribution to this PR happened while he was still at Sony Pictures Imageworks (SPI). Even though he has signed the CLA, the check will fail as the email assigned to this commit is no longer associated with his GitHub account. |
DiegoTavares
force-pushed
the
disable_cuegui_actions
branch
from
8379d58 to
95516cb
Compare
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
changed the title
ramonfigueiredo
approved these changes
Aug 20, 2024
Collaborator
ramonfigueiredo
left a comment
ramonfigueiredo
left a comment
There was a problem hiding this comment.
@DiegoTavares
Approved!
Signed-off-by: Diego Tavares <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a filter, it might be useful for studios to have the ability to prevent some actions from being available according to how their pipelines are configured. For us (Imageworks) for example, the
SET_ALL_RENDER_LAYER_CORESoption was confusing users and we decided to add it to the list of disabled actions.