[cuebot] fix dispatched frame chunk end frame number #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-ubi
force-pushed
the
bug/chunk_end_frame
branch
from
7b773c4
to
083709f
Compare
anton-ubi
changed the title
KernAttila
suggested changes
Aug 27, 2024
cuebot/src/main/java/com/imageworks/spcue/dispatcher/DispatchSupportService.java
Outdated
Show resolved
Hide resolved
cuebot/src/test/java/com/imageworks/spcue/test/util/FrameSetTests.java
Outdated
Show resolved
Hide resolved
Thanks Kern Co-authored-by: Kern Attila GERMAIN <[email protected]> Signed-off-by: Anton Brand <[email protected]>
anton-ubi
requested review from
bcipriano,
DiegoTavares and
ramonfigueiredo
as code owners
DiegoTavares
approved these changes
Aug 29, 2024
DiegoTavares
merged commit 1e4695d
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#1129
Summarize your change.
Fix the frame end resolution of a frame chunk used to fill the place holder
#FRAME_END#.The current behavior incorrectly returns the index of the last frame in the frame list instead of its value.
Leverage
FrameSet.get_chunkmethod that is already doing all the legwork to get the last frame.Related topics