[cuegui] Make frames and layers readonly when a job is finished #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic relied on loading the file every time the widget is reopened. This improvement makes use of the Constants module to store the file attributes.
DiegoTavares
force-pushed
the
frame_readonly
branch
from
05b7b14 to
1dd8189
Compare
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
approved these changes
Aug 14, 2024
Collaborator
ramonfigueiredo
left a comment
ramonfigueiredo
left a comment
There was a problem hiding this comment.
Approved! Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI currently allows editing frames and layers when the job state has completed. This change uses two configuration flags (
finished_jobs_readonly.frame,finished_jobs_readonly.layer) to enable the behavior of making layers and frames readonly upon completion or cancelation.When the flags are set to
Truecompleted jobs can no longer have layers and frames retried, eaten and edited dependencies.