Avoid creating the cuebot connection twice #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoTavares
changed the title
Improve the logic that connects to cuebot to only create the channel once. Previous logic would call setChannel at init and at setFacility.
DiegoTavares
force-pushed
the
pycue_simplify_config
branch
from
25709d8 to
a1d57ff
Compare
DiegoTavares
changed the title
ramonfigueiredo
approved these changes
Jul 17, 2024
Collaborator
ramonfigueiredo
left a comment
ramonfigueiredo
left a comment
There was a problem hiding this comment.
Approved! Thank you!
n-jay
pushed a commit
to n-jay/OpenCue
that referenced
this pull request
Jul 26, 2024
…#1420) Improve the logic that connects to cuebot to only create the channel once. Previous logic would call setChannel at init and at setFacility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the logic that connects to cuebot to only create the channel once. Previous logic would call setChannel at init and at setFacility.