Improve max reserved memory handling #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing cases where Nuke Jobs minMemory requirement are greater than the MEM_RESERVED_MAX, opencue just assigns minMemory to a lower default value. This causes issues where opencue doesn't allot enough memory needed for the job. Increased the max and changed memory handling by assigning the MEM_RESERVED_MAX for cases where minMemory is greater.
|
Collaborator
Author
|
EasyCLA check can be ignore here as @roulaoregan-spi has signed the CLA in the past. |
DiegoTavares
changed the title
ramonfigueiredo
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a job requests more memory than MEM_RESERVED_MAX it should be given the maximum amount of memory possible (
MEM_RESERVED_MAX) and notMEM_RESERVED_DEFAULT. This will give jobs the maximum possible memory if they request more than we can provide.