Recalc subscriptions #1380
Merged
Recalc subscriptions #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is responsible calculate subscription usage for each show and it's previous version had a bug that could lead to negative values.
ramonfigueiredo
approved these changes
Jun 17, 2024
Collaborator
ramonfigueiredo
left a comment
ramonfigueiredo
left a comment
There was a problem hiding this comment.
Thanks, @DiegoTavares
Approved!
| -- | ||
| -- concatenates all tags in host_tag and sets host.str_tags | ||
| -- | ||
| UPDATE subscription SET int_cores = 0; |
Collaborator
There was a problem hiding this comment.
Please include:
UPDATE subscription SET int_gpus = 0;
| -- concatenates all tags in host_tag and sets host.str_tags | ||
| -- | ||
| UPDATE subscription SET int_cores = 0; | ||
| FOR r IN (select show.str_name as show_name, proc.pk_show, alloc.pk_alloc, alloc.str_name as alloc_name, sum(proc.int_cores_reserved) as c |
Collaborator
There was a problem hiding this comment.
Please include sum(proc.int_gpus_reserved) as d after sum(proc.int_cores_reserved) as c,:
sum(proc.int_cores_reserved) as c,
sum(proc.int_gpus_reserved) as d
| BEGIN | ||
| SELECT int_burst INTO cur_burst FROM subscription WHERE pk_alloc=r.pk_alloc AND pk_show=r.pk_show; | ||
| -- Also changing int_burst here to bypass VERIFY_SUBSCRIPTION trigger | ||
| UPDATE subscription SET int_cores = r.c, int_burst = r.c WHERE pk_alloc=r.pk_alloc AND pk_show=r.pk_show; |
Collaborator
There was a problem hiding this comment.
Missing int_burst = r.c:
int_burst = r.c, int_gpus = r.d
pmady
added a commit
to pmady/OpenCue
that referenced
this pull request
Dec 26, 2025
Add recalculateSubscriptions() method to MaintenanceDao interface and its implementation in MaintenanceDaoJdbc. This method calls the recalculate_subs() PostgreSQL function that was added in PR AcademySoftwareFoundation#1380. Part of AcademySoftwareFoundation#1562 Signed-off-by: pmady <[email protected]>
pmady
added a commit
to pmady/OpenCue
that referenced
this pull request
Dec 26, 2025
Add recalculateSubscriptions() method to MaintenanceDao interface and its implementation in MaintenanceDaoJdbc. This method calls the recalculate_subs() PostgreSQL function that was added in PR AcademySoftwareFoundation#1380. Part of AcademySoftwareFoundation#1562 Signed-off-by: pmady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is responsible calculate subscription usage for each show and it's previous version had a bug that could lead to negative values.