Kill job reason #1367
Merged
Kill job reason #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature requires more information from job kill actions requested through the API.
|
Collaborator
Author
|
@roulaoregan-spi has already signed the CLA before, I'm ignoring the EasyCLA |
Signed-off-by: Diego Tavares <[email protected]>
|
|
||
| @Override | ||
| public void killFrames(LayerKillFramesRequest request, StreamObserver<LayerKillFramesResponse> responseObserver) { | ||
| updateLayer(request.getLayer()); |
Collaborator
There was a problem hiding this comment.
Same here:
It is missing the if (attemptChange(env, property, jobManager, layer, responseObserver)) {
New code:
@Override
public void killFrames(LayerKillFramesRequest request, StreamObserver<LayerKillFramesResponse> responseObserver) {
updateLayer(request.getLayer());
if (attemptChange(env, property, jobManager, layer, responseObserver)) {
manageQueue.execute(new DispatchKillFrames(frameSearch,
new Source(request.toString(), request.getUsername(), request.getPid(),
request.getHostKill(), request.getReason()), jobManagerSupport));
responseObserver.onNext(LayerKillFramesResponse.newBuilder().build());
responseObserver.onCompleted();
}
}
DiegoTavares
commented
Jun 17, 2024
cuebot/src/main/java/com/imageworks/spcue/servant/ManageJob.java
Outdated
Show resolved
Hide resolved
Return attemptChange calls that got removed by the merge Signed-off-by: Diego Tavares <[email protected]>
Collaborator
Author
|
@ramonfigueiredo thanks for the review. The proposed changes are in. |
Collaborator
|
Thanks @DiegoTavares |
ramonfigueiredo
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding requester information to JobKillRequest
This feature requires more information from job kill
actions requested through the API.
Link the Issue(s) this Pull Request is related to.
This feature is motivated by a situation where a script was misusing the API and calling kill on all the jobs for a show on a regular basis. Without this feature, finding where the requests were coming from was a big endeavor.
Summarize your change.
This change requires that a kill request also provide username, pid, host_kill and reason.