Fix GUI not updating bugs #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DiegoTavares
commented
Aug 2, 2022
•
DiegoTavares
commented
- Check if regex expression is empty before querying
- Fix JobMonitorTree getJobs call
- Check if regex expression is empty before querying - Reduce timeout to a workable value. According to (gRPC Python docs)[https://grpc.github.io/grpc/python/grpc.html#grpc.UnaryUnaryMultiCallable.__call__], timeout is measured in seconds, meaning the current configuration is 2.7h which doesn't seem useful. Reducing to 10s. - Reducing JobMonitor tick to 10s - Check if regex expression is empty before querying - Fix JobMonitorTree getJobs call
DiegoTavares
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
IdrisMiles and
splhack
as code owners
bcipriano
approved these changes
Sep 14, 2022
|
@DiegoTavares Ping |
DiegoTavares
commented
Jan 29, 2024
Signed-off-by: Diego Tavares da Silva <[email protected]>
DiegoTavares
merged commit 9b4f90f
into
AcademySoftwareFoundation:master
12 checks passed
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
* Fix GUI not updating bugs - Check if regex expression is empty before querying - Reduce timeout to a workable value. According to (gRPC Python docs)[https://grpc.github.io/grpc/python/grpc.html#grpc.UnaryUnaryMultiCallable.__call__], timeout is measured in seconds, meaning the current configuration is 2.7h which doesn't seem useful. Reducing to 10s. - Reducing JobMonitor tick to 10s - Check if regex expression is empty before querying - Fix JobMonitorTree getJobs call * Apply suggestions from code review Signed-off-by: Diego Tavares da Silva <[email protected]> * Update MonitorJobsPlugin.py --------- Signed-off-by: Diego Tavares da Silva <[email protected]>
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
* Fix GUI not updating bugs - Check if regex expression is empty before querying - Reduce timeout to a workable value. According to (gRPC Python docs)[https://grpc.github.io/grpc/python/grpc.html#grpc.UnaryUnaryMultiCallable.__call__], timeout is measured in seconds, meaning the current configuration is 2.7h which doesn't seem useful. Reducing to 10s. - Reducing JobMonitor tick to 10s - Check if regex expression is empty before querying - Fix JobMonitorTree getJobs call * Apply suggestions from code review Signed-off-by: Diego Tavares da Silva <[email protected]> * Update MonitorJobsPlugin.py --------- Signed-off-by: Diego Tavares da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.