Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update akka-http-json4s dependency #1889

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Update akka-http-json4s dependency #1889

merged 1 commit into from
Jul 19, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Jul 19, 2021 •
edited
Loading

Fixes:

021-07-19 12:03:13,504 WARN  akka.util.ManifestInfo - You are using version 10.2.4 of Akka HTTP, but it appears you (perhaps indirectly) also depend on older versions of related artifacts. You can solve this by adding an explicit dependency on version 10.2.4 of the [akka-http] artifacts to your project. Here's a complete collection of detected artifacts: (10.2.0, [akka-http]), (10.2.4, [akka-http-core, akka-parsing]). See also: https://doc.akka.io/docs/akka/current/common/binary-compatibility-rules.html#mixed-versioning-is-not-allowed

@pm47 pm47 requested a review from t-bast July 19, 2021 10:20
t-bast
t-bast approved these changes Jul 19, 2021
View reviewed changes
pom.xml
@@ -58,6 +58,9 @@
<developer>
<id>sstone</id>
</developer>
<developer>
<id>t-bast</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpsons-wouhou

@codecov-commenter
Copy link

Codecov Report

Merging #1889 (8eed3c6) into master (3f1c250) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.01%     
==========================================
  Files         159      159              
  Lines       11995    11995              
  Branches      459      459              
==========================================
- Hits        10472    10471       -1     
- Misses       1523     1524       +1
Impacted Files Coverage Δ
...main/scala/fr/acinq/eclair/router/Validation.scala 90.76% <0.00%> (-1.54%) ⬇️
...clair/channel/publish/ReplaceableTxPublisher.scala 85.79% <0.00%> (-1.19%) ⬇️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 97.63% <0.00%> (+1.57%) ⬆️
...clair/blockchain/bitcoind/rpc/BatchingClient.scala 100.00% <0.00%> (+13.63%) ⬆️

@pm47 pm47 merged commit c8c5e76 into master Jul 19, 2021
@pm47 pm47 deleted the update-deps branch July 19, 2021 12:07
@t-bast t-bast mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm47 @codecov-commenter @t-bast