Parallel payment request generation #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1878 +/- ##
==========================================
+ Coverage 87.27% 87.29% +0.02%
==========================================
Files 159 159
Lines 11943 11948 +5
Branches 471 492 +21
==========================================
+ Hits 10423 10430 +7
+ Misses 1520 1518 -2
|
t-bast
approved these changes
Jul 16, 2021
| case Failure(exception) => ctx.sender ! Status.Failure(exception) | ||
| } | ||
| case receivePayment: ReceivePayment => | ||
| val child = ctx.spawn(CreateInvoiceActor(nodeParams), name = UUID.randomUUID().toString) |
There was a problem hiding this comment.
nit: you don't need to specify a name, you can use spawnAnonymous
There was a problem hiding this comment.
Will fix in a subsequent related PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate the payment request generation, signature and db write to a short-lived child actor.
There is small (~5%) gain in performance in
PerformanceIntegrationSpecbecause what matters is the db write, and it is not parallelized in WAL mode.