Refactor global balance tests #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
previously approved these changes
Jul 15, 2021
Instead of adding bloat to the NormalStateSpec tests.
Remove unnecessary parts that belonged to the NormalStateSpec test.
t-bast
force-pushed
the
refactor-global-balance-tests
branch
from
5917ba5
to
51b0190
Compare
|
Rebased on master. |
pm47
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was OCD-ing over this comment and it was quick to fix, so here it is 😄
I'm moving balance check tests to their own test file instead of making the tests in
NormalStateSpecmore complex than they were.