Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper data type for timestamps in Postgres 2 #1862

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Jul 5, 2021

For some reason, the payments database was forgotten by #1778.

NB: this is missing a migration test.

@pm47 pm47 requested a review from sstone July 5, 2021 16:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #1862 (0ad6f11) into master (85ed433) will decrease coverage by 1.88%.
The diff coverage is 70.94%.

@@            Coverage Diff             @@
##           master    #1862      +/-   ##
==========================================
- Coverage   88.94%   87.06%   -1.89%     
==========================================
  Files         150      156       +6     
  Lines       11239    11723     +484     
  Branches      447      455       +8     
==========================================
+ Hits         9997    10207     +210     
- Misses       1242     1516     +274     
Impacted Files Coverage Δ
...ain/scala/fr/acinq/eclair/balance/Monitoring.scala 0.00% <0.00%> (ø)
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 95.95% <ø> (-0.92%) ⬇️
.../main/scala/fr/acinq/eclair/channel/Register.scala 81.48% <ø> (ø)
...n/scala/fr/acinq/eclair/balance/BalanceActor.scala 11.32% <11.32%> (ø)
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala 51.04% <25.00%> (-1.10%) ⬇️
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala 91.17% <50.00%> (-2.77%) ⬇️
...n/scala/fr/acinq/eclair/json/JsonSerializers.scala 87.17% <55.55%> (ø)
...n/scala/fr/acinq/eclair/balance/CheckBalance.scala 58.82% <58.82%> (ø)
.../src/main/scala/fr/acinq/eclair/db/Databases.scala 82.14% <60.00%> (-3.58%) ⬇️
...c/main/scala/fr/acinq/eclair/db/pg/PgPeersDb.scala 86.36% <60.00%> (-8.51%) ⬇️
... and 28 more

t-bast
t-bast previously approved these changes Jul 5, 2021
@pm47 pm47 removed the request for review from sstone July 5, 2021 18:07
@pm47 pm47 force-pushed the pg-payments-timestamps branch 2 times, most recently from 0ad6f11 to e06c23f Compare July 7, 2021 15:25
@pm47
Copy link
Member Author

pm47 commented Jul 7, 2021

Rebased on parent PR and squashed.

For some reason, the payments database was forgotten by #1778.
@pm47
Copy link
Member Author

pm47 commented Jul 8, 2021

Parent PR was merged, rebased on master.

@pm47 pm47 requested a review from t-bast July 8, 2021 13:51
@pm47 pm47 merged commit cea3fc0 into master Jul 8, 2021
@pm47 pm47 deleted the pg-payments-timestamps branch July 8, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants