Fix default file backup config #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `file-backup` section should be inside `eclair`, otherwise startup fails.
pm47
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Embarrassing. Here is a micro post mortem:
- the bug wasn't caught by the integration tests because we explicitly disable db backups for them (using the correct config path)
- the bug wasn't caught by the
StartupSpectest either because the config isn't handled byNodeParams.
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
- Coverage 88.96% 88.93% -0.03%
==========================================
Files 150 150
Lines 11250 11250
Branches 457 457
==========================================
- Hits 10008 10005 -3
- Misses 1242 1245 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
file-backupsection should be insideeclair, otherwise startup fails.