Decode warning messages #1854
Merged
Decode warning messages #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for logging warning messages as introduced in lightning/bolts#834 Support for sending warning messages instead of current errors will be added in a later PR.
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
==========================================
- Coverage 88.94% 88.94% -0.01%
==========================================
Files 150 150
Lines 11239 11248 +9
Branches 447 449 +2
==========================================
+ Hits 9997 10004 +7
- Misses 1242 1244 +2
|
pm47
reviewed
Jun 30, 2021
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/LightningMessageCodecs.scala
Show resolved
Hide resolved
pm47
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for logging warning messages as introduced in lightning/bolts#834
Support for sending warning messages instead of current errors will be added in a later PR.
Note that c-lightning already sends these messages, so it will be useful to have them correctly logged.
Even if the spec PR is eventually changed, this will not introduce backwards-compatibility issues so IMO it's worth merging on master now.