Schedule backup at regular interval #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit less trigger happy than previously, and the implementation is simpler.
t-bast
reviewed
Jun 23, 2021
eclair-core/src/main/scala/fr/acinq/eclair/db/FileBackupHandler.scala
Outdated
Show resolved
Hide resolved
That way we don't block the actor and prevent messages from piling up in the mailbox.
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
- Coverage 89.09% 88.93% -0.16%
==========================================
Files 146 150 +4
Lines 10994 11237 +243
Branches 444 429 -15
==========================================
+ Hits 9795 9994 +199
- Misses 1199 1243 +44
|
t-bast
reviewed
Jun 23, 2021
t-bast
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit less trigger happy than previously, and the implementation
is simpler.