Symmetrical HTLC limits #1828
Merged
Symmetrical HTLC limits #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec defines `max_accepted_htlcs` and `max_htlc_value_in_flight_msat` to let nodes reduce their exposure to pending HTLCs. This only applies to received HTLCs, and we use the remote peer's values for outgoing HTLCs. But when we're more restrictive than our peer, it makes sense to apply our limits to outgoing HTLCs as well.
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
+ Coverage 89.32% 89.36% +0.03%
==========================================
Files 145 145
Lines 10980 10980
Branches 432 442 +10
==========================================
+ Hits 9808 9812 +4
+ Misses 1172 1168 -4
|
sstone
reviewed
May 28, 2021
| if (outgoingHtlcs.size > commitments1.remoteParams.maxAcceptedHtlcs) { | ||
| return Left(TooManyAcceptedHtlcs(commitments.channelId, maximum = commitments1.remoteParams.maxAcceptedHtlcs)) | ||
| if (Seq(commitments1.localParams.maxAcceptedHtlcs, commitments1.remoteParams.maxAcceptedHtlcs).min < outgoingHtlcs.size) { | ||
| return Left(TooManyAcceptedHtlcs(commitments.channelId, maximum = Seq(commitments1.localParams.maxAcceptedHtlcs, commitments1.remoteParams.maxAcceptedHtlcs).min)) |
There was a problem hiding this comment.
We could also add a new TooManyOfferedHtlcs class here but I agree it's not needed.
sstone
approved these changes
May 28, 2021
sstone
pushed a commit
that referenced
this pull request
Jun 3, 2021
The spec defines `max_accepted_htlcs` and `max_htlc_value_in_flight_msat` to let nodes reduce their exposure to pending HTLCs. This only applies to received HTLCs, and we use the remote peer's values for outgoing HTLCs. But when we're more restrictive than our peer, it makes sense to apply our limits to outgoing HTLCs as well.
sstone
pushed a commit
that referenced
this pull request
Jun 3, 2021
The spec defines `max_accepted_htlcs` and `max_htlc_value_in_flight_msat` to let nodes reduce their exposure to pending HTLCs. This only applies to received HTLCs, and we use the remote peer's values for outgoing HTLCs. But when we're more restrictive than our peer, it makes sense to apply our limits to outgoing HTLCs as well.
dpad85
pushed a commit
that referenced
this pull request
Jun 3, 2021
The spec defines `max_accepted_htlcs` and `max_htlc_value_in_flight_msat` to let nodes reduce their exposure to pending HTLCs. This only applies to received HTLCs, and we use the remote peer's values for outgoing HTLCs. But when we're more restrictive than our peer, it makes sense to apply our limits to outgoing HTLCs as well. Co-authored-by: Bastien Teinturier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec defines
max_accepted_htlcsandmax_htlc_value_in_flight_msatto let nodes reduce their exposure to pending HTLCs. This only applies to received HTLCs, and we use the remote peer's values for outgoing HTLCs.But when we're more restrictive than our peer, it makes sense to apply our limits to outgoing HTLCs as well.