Add metrics on channels processing time #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
=======================================
Coverage 89.33% 89.34%
=======================================
Files 145 145
Lines 10973 10976 +3
Branches 464 450 -14
=======================================
+ Hits 9803 9806 +3
Misses 1170 1170
|
t-bast
approved these changes
May 26, 2021
It should be properly sampled by Kamon AFAIK? |
It's probably ok (and we have more noisy metrics like signing in the key manager), we'll see later if that becomes an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's similar with built-in akka metrics, but with message-type granularity.