Api fixes #1819
Merged
Api fixes #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow plugins to properly initialize before providing their routes.
Codecov Report
@@ Coverage Diff @@
## master #1819 +/- ##
==========================================
+ Coverage 89.29% 89.39% +0.09%
==========================================
Files 143 145 +2
Lines 10948 11030 +82
Branches 480 466 -14
==========================================
+ Hits 9776 9860 +84
+ Misses 1172 1170 -2
|
t-bast
reviewed
May 25, 2021
|
Yes, it has been. |
t-bast
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of follow up fixes for plugin API support.
First commit is important and second one is just a refactoring and code update to remove a deprecation warning.