Check blockchain watchdogs regularly #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to check secondary blockchain sources when we haven't received blocks in a while. Fixes #1803
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
- Coverage 89.33% 89.29% -0.05%
==========================================
Files 143 143
Lines 10932 10934 +2
Branches 481 467 -14
==========================================
- Hits 9766 9763 -3
- Misses 1166 1171 +5
|
pm47
approved these changes
May 17, 2021
| Behaviors.receiveMessage { | ||
| case NoBlockReceivedSince(lastBlockCount) => | ||
| context.self ! CheckLatestHeaders(lastBlockCount) | ||
| timers.startSingleTimer(NoBlockReceivedTimer, NoBlockReceivedSince(lastBlockCount), blockTimeout) |
There was a problem hiding this comment.
Doc:
if a new timer with same key is started the previous is cancelled.
So timers.startSingleTimer effectively resets the timer. ✔️
There was a problem hiding this comment.
Yes, that's why I chose the overload with a key ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to check secondary blockchain sources when we haven't received blocks in a while.
Thanks @engenegr and @btcontract for raising this.
Fixes #1803