Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use satoshi for htlc ordering #1806

Merged
merged 1 commit into from
May 17, 2021
Merged

Use satoshi for htlc ordering #1806

merged 1 commit into from
May 17, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented May 16, 2021

Reproduce and fix the spec violation. Updated the test vectors according to lightning/bolts#872 (comment).

Fixes #1804.

@codecov-commenter
Copy link

Codecov Report

Merging #1806 (e6e1cc1) into master (898c17b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1806   +/-   ##
=======================================
  Coverage   89.31%   89.31%           
=======================================
  Files         143      143           
  Lines       10929    10929           
  Branches      468      468           
=======================================
  Hits         9761     9761           
  Misses       1168     1168           
Impacted Files Coverage Δ
...la/fr/acinq/eclair/transactions/Transactions.scala 96.78% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 96.09% <0.00%> (-1.57%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.31% <0.00%> (+0.08%) ⬆️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 85.10% <0.00%> (+0.42%) ⬆️

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pm47 pm47 merged commit ec276f8 into master May 17, 2021
@pm47 pm47 deleted the htlc-compare branch May 17, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Satoshi amounts must be used for htlc comparison
3 participants