Allow plugins to inject their own routes into API #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ApiExtendingPlugin trait
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
==========================================
- Coverage 89.34% 89.33% -0.02%
==========================================
Files 144 143 -1
Lines 10934 10929 -5
Branches 458 468 +10
==========================================
- Hits 9769 9763 -6
- Misses 1165 1166 +1
|
t-bast
reviewed
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on a discussion at #1800
With new approach plugins may extend
RouteProvidertrait and inject their own routes into a single Eclair API endpoint.I could not find any apparent way to check if any route names clash, maybe this can be dealt with by recommending each API-enabled plugin to prefix its API commands as "plugin_name-command".