Use less strict isolation level for channel meta #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need `SERIALIZABLE` consistency guarantees when all we do is updating timestamp columns. This happens concurrently to channel data update and raised serialization errors in postgres. Fixed #1786.
Codecov Report
@@ Coverage Diff @@
## master #1790 +/- ##
==========================================
- Coverage 89.34% 89.33% -0.01%
==========================================
Files 144 144
Lines 10934 10935 +1
Branches 458 452 -6
==========================================
Hits 9769 9769
- Misses 1165 1166 +1
|
t-bast
previously approved these changes
May 8, 2021
eclair-core/src/test/scala/fr/acinq/eclair/db/ChannelsDbSpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Teinturier <[email protected]>
t-bast
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need
SERIALIZABLEconsistency guarantees when all we do isupdating timestamp columns. This happens concurrently to channel data
update and raised serialization errors in postgres.
Fixed #1786.