Add additional PRNG #1774
Merged
Add additional PRNG #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
secondary-random-generator
branch
2 times, most recently
from
d152522
to
dd903c4
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1774 +/- ##
==========================================
+ Coverage 89.27% 89.38% +0.10%
==========================================
Files 143 145 +2
Lines 10948 11030 +82
Branches 480 466 -14
==========================================
+ Hits 9774 9859 +85
+ Misses 1174 1171 -3
|
t-bast
force-pushed
the
secondary-random-generator
branch
from
99da5a4
to
1c31cf7
Compare
pm47
reviewed
Apr 23, 2021
t-bast
force-pushed
the
secondary-random-generator
branch
2 times, most recently
from
35037f1
to
0df44d9
Compare
pm47
requested changes
May 17, 2021
eclair-core/src/main/scala/fr/acinq/eclair/crypto/WeakEntropyPool.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/crypto/keymanager/LocalChannelKeyManager.scala
Outdated
Show resolved
Hide resolved
In case of catastrophic failures of the `SecureRandom` instance, we add a secondary randomness source that we mix into the random stream. This is a somewhat weak random source and should not be used on its own, but it doesn't hurt to xor it with the output of `SecureRandom`. We use an actor that listens to events in the system and inject them in our weak pseudo-RNG.
These functions have side-effects, it was incorrect and misleading to expose them without parenthesis.
t-bast
force-pushed
the
secondary-random-generator
branch
from
1e9f0ce
to
1e1037f
Compare
|
Let's wait for a full review from @sstone before merging. |
sstone
reviewed
May 17, 2021
ChaCha20 is designed to allow encrypting directly inside the plaintext array to avoid allocating another array for the ciphertext. We add a test case to ensure this is working as expected.
sstone
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of catastrophic failures of the
SecureRandominstance, we add a secondary randomness source that we mix into the random stream.This is a somewhat weak random source and should not be used on its own, but it doesn't hurt to xor it with the output of
SecureRandom.The second commit should be reviewed independently: it simply adds parenthesis to functions that generate random things, since these have side-effects. It's trivial but painful to review since it touches a lot of test files.
NB: this feature make a lot of sense in https://github.com/acinq/lightning-kmp as well since mobile platforms may have more common randomness failures.