Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not explicitly provide address for ServerSocket #1766

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Do not explicitly provide address for ServerSocket #1766

merged 1 commit into from
Apr 14, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented Apr 13, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1766 (3362e88) into master (ccae92d) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
+ Coverage   89.25%   89.32%   +0.07%     
==========================================
  Files         144      144              
  Lines       10824    10824              
  Branches      473      473              
==========================================
+ Hits         9661     9669       +8     
+ Misses       1163     1155       -8     
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.54% <0.00%> (-0.09%) ⬇️
...cala/fr/acinq/eclair/crypto/TransportHandler.scala 90.76% <0.00%> (+0.54%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 95.52% <0.00%> (+1.49%) ⬆️
...main/scala/fr/acinq/eclair/router/Validation.scala 92.30% <0.00%> (+1.53%) ⬆️
...cinq/eclair/blockchain/bitcoind/zmq/ZMQActor.scala 95.00% <0.00%> (+5.00%) ⬆️

@pm47
Copy link
Member Author

pm47 commented Apr 13, 2021

Ran the tests 3 times, no issues. 🤞

@pm47 pm47 marked this pull request as ready for review April 13, 2021 18:28
@pm47 pm47 requested a review from t-bast April 13, 2021 18:29
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@pm47 pm47 merged commit eb834e2 into master Apr 14, 2021
@pm47 pm47 deleted the fix-tests branch April 14, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants