Catch all connection failures and reconnect #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ReconnectionTask` was only catching `ConnectionResult.Failure.ConnectionFailed`, which is a subset of possible failures. It should instead have caught `ConnectionResult.Failure`. All authentication and initialization failures were not caught and didn't trigger reconnections.
t-bast
reviewed
Apr 9, 2021
t-bast
previously approved these changes
Apr 12, 2021
eclair-core/src/test/scala/fr/acinq/eclair/io/ReconnectionTaskSpec.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Teinturier <[email protected]>
t-bast
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReconnectionTaskwas only catchingConnectionResult.Failure.ConnectionFailed, which is a subset ofpossible failures. It should instead have caught
ConnectionResult.Failure.All authentication and initialization failures were not caught and
didn't trigger reconnections.
Fixes #1748.