Database nits #1755
Merged
Database nits #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the `TestDatabases` is instantiated, calling `dbs.dbName` twice was a no-op.
Codecov Report
@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 89.21% 89.18% -0.04%
==========================================
Files 143 143
Lines 10769 10769
Branches 464 464
==========================================
- Hits 9608 9604 -4
- Misses 1161 1165 +4
|
t-bast
reviewed
Apr 6, 2021
eclair-core/src/test/scala/fr/acinq/eclair/db/AuditDbSpec.scala
Outdated
Show resolved
Hide resolved
t-bast
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are best reviewed independently.