Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make signing payment requests faster #1754

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Make signing payment requests faster #1754

merged 3 commits into from
Apr 2, 2021

Conversation

sstone
Copy link
Member

@sstone sstone commented Apr 2, 2021

There was a much more efficient method to compute the pukey recovery id that was not used.

@sstone
Make signing payment requests faster
8a3e4fa 
There was a much more efficient method to compute the pukey recovery id that was not used.
@sstone sstone requested a review from t-bast April 2, 2021 12:37
t-bast
t-bast approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we indeed dived a bit into it when doing the signMessage API but didn't think to change it here.

@sstone sstone merged commit 1321761 into master Apr 2, 2021
@sstone sstone deleted the pr-sign-faster branch April 2, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sstone @pm47 @t-bast