Add blocking option to payinvoice API #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1751 +/- ##
==========================================
- Coverage 87.27% 87.18% -0.09%
==========================================
Files 154 154
Lines 11989 12006 +17
Branches 508 522 +14
==========================================
+ Hits 10463 10468 +5
- Misses 1526 1538 +12
|
Add an option to block until the payment completes to the payinvoice API. This can be simpler to use for payments that complete quickly.
t-bast
force-pushed
the
send-payment-blocking
branch
from
99e62d3
to
f8c9ced
Compare
sstone
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to block until the payment completes to the
payinvoiceAPI.This can be simpler to use for payments that complete quickly than polling the inefficient
getsentinfoAPI.