Remove Electrum support #1750
Merged
Remove Electrum support #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Electrum support was provided for mobile wallets, server nodes should always run a bitcoind node as this provides more control (especially for utxo management for anchor outputs channels). Since wallets will use https://github.com/acinq/eclair-kmp instead of eclair, we can now remove Electrum and API fee providers from eclair.
t-bast
commented
Apr 1, 2021
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/WatcherTypes.scala
Outdated
Show resolved
Hide resolved
pm47
reviewed
Apr 1, 2021
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/WatcherTypes.scala
Outdated
Show resolved
Hide resolved
pm47
previously approved these changes
Apr 1, 2021
pm47
approved these changes
Apr 2, 2021
t-bast
added a commit
that referenced
this pull request
Apr 2, 2021
It was only used by Electrum which was removed in #1750
t-bast
added a commit
that referenced
this pull request
Apr 2, 2021
It was only used by Electrum which was removed in #1750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electrum support was provided for mobile wallets, server nodes should always run a bitcoind node as this provides more control (especially for utxo management for anchor outputs channels).
Since wallets will use https://github.com/acinq/eclair-kmp instead of eclair, we can now remove Electrum and API fee providers from eclair.
10k lines of code removed, it's quite a feat! Eclair is now down to ~30k lines of code ;)