Shortest paths: prevent producing loops and remove some duplicated work #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Mar 31, 2021
eclair-core/src/test/scala/fr/acinq/eclair/router/RouteCalculationSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/router/RouteCalculationSpec.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/router/RouteCalculationSpec.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
- Coverage 86.67% 86.47% -0.20%
==========================================
Files 154 154
Lines 11996 12004 +8
Branches 516 528 +12
==========================================
- Hits 10397 10381 -16
- Misses 1599 1623 +24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to
yenKshortestPaths:yenKshortestPathsbackwards like what is already done indijkstraShortestPath. It allows to compute the correct weights directly.dijkstraShortestPathseveral times on the same input by only computing spur paths for new edges.shortestPaths(k)often has a lot of overlap with the previousshortestPathsso a lot of the poential spur nodes were already considered.