Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle aggregated anchor outputs htlc txs #1738

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Handle aggregated anchor outputs htlc txs #1738

merged 3 commits into from
Mar 25, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Mar 23, 2021

An interesting side-effect of anchor outputs is that htlc txs can be merged when they have the same lockTime (thanks to sighash flags).

We're not currently doing that, but our peers may do it, so we need to handle it in the revoked commit tx case and correctly claim multiple outputs if necessary.

@t-bast
Handle aggregated anchor outputs htlc txs
85baac4 
An interesting side-effect of anchor outputs is that htlc txs can be merged
when they have the same lockTime (thanks to sighash flags).

We're not currently doing that, but our peers may do it, so we need to handle
it in the revoked commit tx case and correctly claim multiple outputs if
necessary.
@t-bast t-bast requested a review from pm47 March 23, 2021 14:07
@t-bast t-bast merged commit c37eb1a into master Mar 25, 2021
@t-bast t-bast deleted the claim-revoked-multiple-htlcs branch March 25, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bast @pm47