Clarify some comments and add tests #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
previously approved these changes
Mar 23, 2021
This commit clarifies some parts of the code on which we regularly have questions during pull requests. We also add a test for an edge case in shutdown that was correctly handled, but not properly tested, to ensure non-regression.
t-bast
force-pushed
the
add-tests-clarify
branch
from
c0e2ab1
to
7d1fea1
Compare
|
Rebased |
pm47
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clarifies some parts of the code on which we regularly have questions during pull requests.
We also add a test for an edge case in shutdown that was correctly handled, but not properly tested, to ensure non-regression.