Reorganize internal codecs (master) #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to ensure maximum safety when migrating data. To achieve this, we strictly segregate each codec version (to make sure that we don't accidentally mix codec versions), while still letting tests access each unitary codecs (which using inner `private classes` would have prevented). Relevant tests only need to be moved to the appropriate package. The package structure is now: ``` wire | `-- internal | | | `-- channel | | | | | `-- version0 | | | | | | | `-- ChannelCodecs0 | | | | | `-- version1 | | | | | | | `-- ChannelCodecs1 | | | | | `-- ChannelCodecs | | | `-- CommandCodecs | `-- others ```
t-bast
reviewed
Mar 19, 2021
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/ChannelCodecs.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/ChannelCodecs.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version1/ChannelCodecs1.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version1/ChannelCodecs1.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
==========================================
- Coverage 86.35% 86.33% -0.03%
==========================================
Files 151 152 +1
Lines 11781 11784 +3
Branches 498 497 -1
==========================================
Hits 10174 10174
- Misses 1607 1610 +3
|
tompro
pushed a commit
to tompro/eclair
that referenced
this pull request
Mar 21, 2021
The goal is to ensure maximum safety when migrating data. To achieve this, we strictly segregate each codec version (to make sure that we don't accidentally mix codec versions), while still letting tests access each unitary codecs (which using inner `private classes` would have prevented). Relevant tests only need to be moved to the appropriate package. The package structure is now: ``` wire | `-- internal | | | `-- channel | | | | | `-- version0 | | | | | | | `-- ChannelCodecs0 | | | | | `-- version1 | | | | | | | `-- ChannelCodecs1 | | | | | `-- ChannelCodecs | | | `-- CommandCodecs | `-- others ``` Co-authored-by: Bastien Teinturier <[email protected]>
t-bast
added a commit
that referenced
this pull request
Mar 23, 2021
This is a follow-up for #1732 Codecs in the protocol package will always be backwards-compatible, as they are defined in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #1731, but applied on master instead of on top of #1728.
The goal is to ensure maximum safety when migrating data.
To achieve this, we strictly segregate each codec version (to make sure
that we don't accidentally mix codec versions), while still letting
tests access each unitary codecs (which using inner
private classeswould have prevented). Relevant tests only need to be moved to the
appropriate package.
The package structure is now: