Trampoline fast fail #1727
Merged
Trampoline fast fail #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
t-bast
reviewed
Mar 9, 2021
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
tompro
pushed a commit
to tompro/eclair
that referenced
this pull request
Mar 21, 2021
When we receive a trampoline payment asking us to relay with an expiry that is already below the current chain height, we know that this payment will fail when it reaches the next trampoline node. Instead of waiting for the next trampoline node to reject it, we reject it immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail relayed trampoline payment if we see that
payloadOut.outgoingCltvis below chain height. It's not our problem if it is but it makes sense to not risk our funds for a payment which will be failed by rational receivers.