Clarify commit tx fee anchor cost #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since anchor outputs, we not only deduce the commit tx fee from the funder's main output but the cost of the anchors as well. We rename the function that does that for more clarity.
In some tests, we're only interested in the commit tx fee, not the cost of the anchors.
pm47
reviewed
Mar 23, 2021
| * If you are adding multiple fees together for example, you should always add them in MilliSatoshi and then round | ||
| * down to Satoshi. | ||
| */ | ||
| def toDeduceFromFunderOutputMsat(dustLimit: Satoshi, spec: CommitmentSpec, commitmentFormat: CommitmentFormat): MilliSatoshi = { |
There was a problem hiding this comment.
I think I would have gone with commitTxFeeMsat and commitTxTotalCostMsat
Suggested change
| def toDeduceFromFunderOutputMsat(dustLimit: Satoshi, spec: CommitmentSpec, commitmentFormat: CommitmentFormat): MilliSatoshi = { | |
| def commitTxTotalCostMsat(dustLimit: Satoshi, spec: CommitmentSpec, commitmentFormat: CommitmentFormat): MilliSatoshi = { |
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
+ Coverage 86.30% 86.65% +0.35%
==========================================
Files 151 154 +3
Lines 11701 11988 +287
Branches 501 511 +10
==========================================
+ Hits 10098 10388 +290
+ Misses 1603 1600 -3
|
pm47
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since anchor outputs, we not only deduce the commit tx fee from the funder's main output but the cost of the anchors as well.
We rename the function that does that for more clarity as it came up in multiple reviews as something that was a bit confusing.
The change is split in two commits to make it easier to verify that there's no regression: