Fix Bolt 3 spec change that broke our test suite #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
approved these changes
Mar 5, 2021
tompro
pushed a commit
to tompro/eclair
that referenced
this pull request
Mar 7, 2021
We just merged lightning/bolts@b201efe in the spec which added Bolt 3 tests, invalidating one of our tests and failing the build.
pm47
pushed a commit
that referenced
this pull request
Apr 1, 2021
We just merged lightning/bolts@b201efe in the spec which added Bolt 3 tests, invalidating one of our tests and failing the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just merged lightning/bolts@b201efe in the spec which added Bolt 3 tests, thus invalidating one of our tests and failing the build.