Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features should be a Map #1715

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Features should be a Map #1715

merged 2 commits into from
Mar 4, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Mar 3, 2021

We previously used a Set, which means you could theoretically have a feature that is both activated as optional and mandatory.
We change that to be a Map feature -> support.

@t-bast
Features should be a Map
5962947 
We previously used a Set, which means you could theoretically have a feature
that is both activated as `optional` and `mandatory`.

We change that to be a Map `feature -> support`.
@t-bast
Clean-up wumbo test tag usage
d56dc64
@t-bast t-bast requested a review from pm47 March 3, 2021 15:57
@t-bast t-bast merged commit 844829a into master Mar 4, 2021
@t-bast t-bast deleted the feature-map branch March 4, 2021 07:41
tompro pushed a commit to tompro/eclair that referenced this pull request Mar 7, 2021
@t-bast @tompro
Features should be a Map (ACINQ#1715)
820ee04 
We previously used a Set, which means you could theoretically have a feature
that is both activated as `optional` and `mandatory`.

We change that to be a Map `feature -> support`.
@t-bast t-bast mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm47 pm47 pm47 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-bast @pm47