Set anchor output feerates when force-closing #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
anchor-output-closing-fees
branch
from
e61504c
to
fa345d3
Compare
pm47
reviewed
Feb 23, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/transactions/Transactions.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Helpers.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Good catch, this is a bit counter-intuitive, I remember we already had a discussion around it when it was first introduced. |
pm47
reviewed
Feb 24, 2021
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Show resolved
Hide resolved
t-bast
force-pushed
the
anchor-output-closing-fees
branch
from
090f7cb
to
a0d48a8
Compare
pm47
reviewed
Feb 24, 2021
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
When using anchor outputs, the commitment feerate is kept low (<10 sat/byte). When we need to force-close a channel, we must ensure the commit tx and htlc txs confirm before a given deadline, so we need to increase their feerates. This is currently done only once, at broadcast time. We use CPFP for the commit tx and RBF for the htlc txs. If publishing fails because we don't have enough utxos available, it will be retried after the next block is confirmed. Note that it's still not recommended to activate anchor outputs. More work needs to be done on this fee bumping logic and utxos management.
It's a bit counter-intuitive that we deduce anchor amounts in this function, because it's not technically a fee.
t-bast
force-pushed
the
anchor-output-closing-fees
branch
from
378108a
to
5b072b1
Compare
pm47
approved these changes
Feb 24, 2021
tompro
pushed a commit
to tompro/eclair
that referenced
this pull request
Mar 7, 2021
When using anchor outputs, the commitment feerate is kept low (<10 sat/byte). When we need to force-close a channel, we must ensure the commit tx and htlc txs confirm before a given deadline, so we need to increase their feerates. This is currently done only once, at broadcast time. We use CPFP for the commit tx and RBF for the htlc txs. If publishing fails because we don't have enough utxos available, it will be retried after the next block is confirmed. Note that it's still not recommended to activate anchor outputs. More work needs to be done on this fee bumping logic and utxos management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using anchor outputs, the commitment feerate is kept low (<10 sat/byte).
When we need to force-close a channel, we must ensure the commit tx and htlc txs confirm before a given deadline, so we need to increase their feerates.
This is currently done only once, at broadcast time. We use CPFP for the commit tx and RBF for the htlc txs.
If publishing fails because we don't have enough utxos available, it will be retried after the next block is found.
The RBF/CPFP logic requires asynchronous calls to
bitcoind, which is why we couldn't just do it in theChanneldirectly without making the channel state machine more complex (and it's already complex enough).This PR is a good starting point, but it's still not recommended to activate anchor outputs on your node. More re-architecting works needs to happen to make the CPFP/RBF story more seamless; in the longer term the channel should not care at all about how txs get confirmed. But it would be nice to get this PR included in the next release, as it still hits a first important milestone.