Remote failure updating routing hint #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routing hint we get in a Bolt 11 invoice may be obsolete when we attempt the payment: one of the nodes in the route may have updated his relay fees. Since this affects a private channel that is not kept in the routing graph, we need to update the routing hints before injecting them in the router. This was already done in `PaymentLifecycle` with automatic retries, but when using MPP we retried in the `MultiPartPaymentLifecycle` instead of inside the `PaymentLifecycle`, so we need to handle routing hints updates there.
pm47
approved these changes
Feb 1, 2021
t-bast
added a commit
that referenced
this pull request
Feb 1, 2021
The routing hint we get in a Bolt 11 invoice may be obsolete when we attempt the payment: one of the nodes in the route may have updated his relay fees. Since this affects a private channel that is not kept in the routing graph, we need to update the routing hints before injecting them in the router. This was already done in `PaymentLifecycle` with automatic retries, but when using MPP we retried in the `MultiPartPaymentLifecycle` instead of inside the `PaymentLifecycle`, so we need to handle routing hints updates there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routing hint we get in a Bolt 11 invoice may be obsolete when we attempt the payment: one of the nodes in the route may have updated his relay fees.
Since this affects a private channel that is not kept in the routing graph, we need to update the routing hints before injecting them in the router. This was already done in
PaymentLifecyclewith automatic retries, but when using MPP we retried in theMultiPartPaymentLifecycleinstead of inside thePaymentLifecycle, so we need to handle routing hints updates there.NB: don't forget to cherry-pick this commit on the
androidbranch to ensureeclair-mobilegets this fix.