Update relay fees from eclair.conf #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
==========================================
+ Coverage 85.95% 86.03% +0.07%
==========================================
Files 151 151
Lines 11474 11483 +9
Branches 495 495
==========================================
+ Hits 9863 9879 +16
+ Misses 1611 1604 -7
|
Clarify why we don't actively update channel relay fees when the default values change in eclair.conf. It would override manual changes made via the API which is bad.
t-bast
force-pushed
the
update-relay-fee-from-conf
branch
from
2712924
to
c6ea5aa
Compare
|
This could be a problem for people who fine-tune their relay fees channel per channel, because all the fees are overriden at restart. I believe we should keep the behavior as it is currently (maybe adding a comment to explain why we keep the existing fees), and tell users to use the API if they want to mass-update their relay fees settings. |
pm47
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
eclair.confchanges while we're offline, we want to apply the fee changes to existing channels once they come back online.