Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bug): Update README + add async install #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kolyaventuri
Copy link

What

  • Adds installAsync as a non-breaking alternative to `install``
    • Removes need for callback
  • Updates README to reflect need for install before start

Why

Using the install method as-is results in a situation where at worst, the server cannot be started, and at best there's a race condition, as the following start method does not wait for completion of the installation, and would subsequently fail
image
Code run in the above screenshot:

var dynamodbLocal = require('dynamodb-localhost');
dynamodbLocal.install();
dynamodbLocal.start({port: 8000});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant