Skip to content

Conversation

@RyanFelt
Copy link
Contributor

@RyanFelt RyanFelt commented Feb 28, 2019

Replaces rmdir package with rimraf, rimraf is a widely used replacement to rmdir that does not have the same vulnerabilities. I saw the issue and didn't know how to proceed to help, I know there already is a PR on this issue.

I have tested and this works on windows. Let me know if you need anything!

Copy link

@RishikeshDarandale RishikeshDarandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RishikeshDarandale
Copy link

Any update when this can be merged?

@RyanFelt
Copy link
Contributor Author

Unfortunately this repo doesn't seem to be to active :(

@AshanFernando AshanFernando merged commit b980c08 into 99x:master Apr 13, 2019
@AshanFernando
Copy link
Collaborator

@RyanFelt @RishikeshDarandale Thanks for the PR.

Sorry for the late reply as of most of us are on holidays. However, the PR is now merged. We will update the NPM adding few more changes with the next release.

@RishikeshDarandale
Copy link

@AshanFernando , when is next release scheduled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants