Skip to content

Include page data in navigation entry #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zachleat merged 3 commits into from
Mar 19, 2025
Merged

Include page data in navigation entry #34

zachleat merged 3 commits into from
Mar 19, 2025

Conversation

@noelleleigh
Copy link
Contributor

@noelleleigh noelleleigh commented Nov 4, 2021

Fixes #17
Fixes #27

inetbiz
inetbiz reviewed May 7, 2022
View reviewed changes
Copy link

@inetbiz inetbiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d5dfcfa#499 Sample data should be more inline with real-world taxonomies. If robot is one, the other might be AI?

@nford
Copy link

nford commented May 15, 2022

@inetbiz can this be merged?

@inetbiz
Copy link

inetbiz commented May 15, 2022

@inetbiz can this be merged?

I don't maintain the repo.

@nford
Copy link

nford commented May 15, 2022

@inetbiz can this be merged?

I don't maintain the repo.

Sorry, that should have been directed to @zachleat

@Dexus
Copy link

Dexus commented Sep 12, 2023

@zachleat @binyamin Please!

@rzelnik rzelnik mentioned this pull request Jan 11, 2024
Open
@Ryuno-Ki
Copy link

Ryuno-Ki commented Dec 23, 2024

Ping @zachleat

@zachleat zachleat merged commit 4c25001 into 11ty:master Mar 19, 2025
@zachleat zachleat added this to the Eleventy Navigation 1.0.0 milestone Mar 19, 2025
@zachleat
Copy link
Member

zachleat commented Mar 19, 2025

Shipping with Navigation v1.0.0

@noelleleigh noelleleigh deleted the page-data branch March 19, 2025 20:32
@zachleat
Copy link
Member

zachleat commented Mar 19, 2025

After some pre-release preliminary testing, this one has a significant performance cost: this change made my build jump from 6.56s to 54.49s.

zachleat added a commit that referenced this pull request Mar 19, 2025
@zachleat
Fixes performance issues in #34 without copying data (a little bit mo…
391b708 
…re risky)
@zachleat
Copy link
Member

zachleat commented Mar 19, 2025

I removed the slow data copy portion of this new feature to fix the performance issues so we’ll still ship this one but do keep in mind that this change is a bit riskier (as this data is mutable)

@noelleleigh
Copy link
Contributor Author

noelleleigh commented Mar 19, 2025

I removed the slow data copy portion of this new feature to fix the performance issues so we’ll still ship this one but do keep in mind that this change is a bit riskier (as this data is mutable)

No worries, thanks for getting around to this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachleat zachleat zachleat approved these changes

+3 more reviewers

@inetbiz inetbiz inetbiz left review comments

@redmagic redmagic redmagic approved these changes

@RogierKonings RogierKonings RogierKonings approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

Eleventy Navigation 1.0.0

Development

Successfully merging this pull request may close these issues.

Include a page's complete frontmatter in its navigation entry Accessing page front matter when looping through eleventy-navigation keys

8 participants

@noelleleigh @nford @inetbiz @Dexus @Ryuno-Ki @zachleat @redmagic @RogierKonings