-
-
Notifications
You must be signed in to change notification settings - Fork 17
change sorting #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change sorting #32
Conversation
allow better sorting. pages that have an order command are now always first, not last.
make sorting even better: - not only numeric but also alphabetic sorting - elements with an order are the first ones listed - backwardscompatibilty with 'order: 0' (exluded from priorization)
I am no javascript specialist. hope the code change is fine. i am aware that maybe the syntax can be made easier, but I don't know how this can be done. I have tested everything on my local environment and it looks fine and do what it needs. |
@zachleat Can you please merge? |
@zachleat, can you please merge? I heavily depend on this PR and the upcoming release :) |
@zachleat Please merge this ASAP as I need this in my project. Thanks |
It'd be great to see this merged! |
Here's a filter to sort by name if anyone needs it. It ignores
usage: |
@mrtnmgs That was a really useful snippet given that there is no response to this PR for a couple of years so thank you! May I ask, how did you work on it? Just dump the output of |
I don't have write access to this repository. Sorry. |
Went with a simpler approach here that only required modification of the |
Correction: the correct fix for this has shipped with Navigation v1.0.1 |
allow better sorting. pages that have an order command are now always first, not last.
this will fix #1